Bumped Gradle, Loom, dependencies versions

Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.

Other

72 stars 24 forks source link

Bumped Gradle, Loom, dependencies versions #186

Closed lospejos closed 1 year ago

Noaaan commented 1 year ago

This PR seems to do a little bit more than just bump versions, like pre-maturely bumping the main mod version and including static analysis. Care to describe why?

lospejos commented 1 year ago

I updated the minor version of mod to reflect that this build has slight changes comparing to previous version.

Regarding including static analysis I'm afraid didn't get you properly. If you meant adding a findbug dependency, I made it because in modern Java versions some annotations were removed (particularly NotNull). I've added findbug dependency to support removed annotations.

lospejos commented 1 year ago

See attached review comments

Thanks for your review, I appreciate it. I suppose that I've fixed all by your comments and I made a new commit.