search

Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
72 stars 24 forks source link

Add German translation #187

Closed Kurty00 closed 3 months ago

Noaaan commented 11 months ago

Bumping this issue, as it seems to be stale

Kurty00 commented 11 months ago

Bumping this issue, as it seems to be stale

Sorry, didn't have much time lately... I fixed some of the untranslated strings in the most recent commit now.

Noaaan commented 11 months ago

All good. Gonna try to get a proper review of this so its merged next week 👍

Kurty00 commented 10 months ago

Bumping this pr, as it seems to be stale.

Noaaan commented 8 months ago

Sorry for this taking so long. Holidays set up all my german translation reviewers to be busy, including glisco. I have found someone with more MM knowledge to finally review the translation, and it should hopefully be done in the coming days/weeks. Going to post one of the review comments here, and add the rest of them once the review is complete.

Kurty00 commented 6 months ago

Alright, I addressed most of the issues you/your second party noted. If I didn't, I should have provided comments. Happy Easter!

Kurty00 commented 3 months ago

I addressed the previously unresolved notes.

Noaaan commented 3 months ago

Ah thank you! Just to let you know, I plan on having this merged for the last 1.20 release, followed by porting it to 1.20.6+. A sidenote: some of the tag translations might change for the port, due to the major tag unification between NeoForge and Fabric. I would appreciate if you are available to look at it when the time comes

Kurty00 commented 3 months ago

If you need me to look at some changes in the translation, feel free to contact me.