Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
73 stars 25 forks source link

Possible return of an issue thought to be fixed #192

Closed Sunconure11 closed 9 months ago

Sunconure11 commented 9 months ago

https://gist.github.com/Sunconure11/01c99152d82325ad12b4949e5c4e8a94

https://github.com/Noaaan/MythicMetals/issues/84#issuecomment-1732421960

Found this while trying to fix an unrelated issue, which is the mod count of my pack, as it may be having packet issues, even with mods meant to solve it.

Noaaan commented 9 months ago

This issue is not the same as #84, they are completely unrelated. I am also not able to reproduce this with only Mythic Metals and Connectivity, both on Fabric and Quilt. From digging through your log there seems to be a ton of unresolved conflicts in general regarding packets, for example the fact that you have at least three different mods redirecting packets:

[14:08:25] [main/WARN]: @ModifyConstant conflict. Skipping #connectivity:connectivity.mixins.json:ClientboundCustomPayloadPacketMixin from mod connectivity->@ModifyConstant::modifyLimit(I)I with priority 1, already redirected by #packetfixer:packetfixer.mixins.json:CustomPayloadS2CPacketMixin from mod packetfixer->@ModifyConstant::newSize(I)I with priority 9999
[14:08:25] [main/WARN]: @ModifyConstant conflict. Skipping #connectivity:connectivity.mixins.json:ClientboundCustomPayloadPacketMixin from mod connectivity->@ModifyConstant::modifyLimit(I)I with priority 1, already redirected by #thiccpackets:xlpackets.mixins.json:ClientboundCustomPayloadPacketMixin from mod thiccpackets->@ModifyConstant::xlPackets(I)I with priority 1000
[14:08:25] [main/WARN]: @ModifyConstant conflict. Skipping #thiccpackets:xlpackets.mixins.json:ClientboundCustomPayloadPacketMixin from mod thiccpackets->@ModifyConstant::xlPackets(I)I with priority 1000, already redirected by #packetfixer:packetfixer.mixins.json:CustomPayloadS2CPacketMixin from mod packetfixer->@ModifyConstant::newSize(I)I with priority 9999

I think your best bet for reproducing here is unfortunately binary searching, as I am unsure what is causing this problem.

Sunconure11 commented 9 months ago

I think I know the issue here, then