search

Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
72 stars 24 forks source link

Added anvils to the "minecraft:anvil" tag. #212

Closed N0aW closed 9 months ago

Noaaan commented 10 months ago

Hey, thanks for the PR. I am considering whether to accept this, as it is somewhat inconsistent with the current anvil handling. Since you are able to disable the anvils via the config, they are dynamically injected into the tags in order to prevent the tags from breaking. A snippet of this can be seen here: https://github.com/Noaaan/MythicMetals/blob/0e57a4a95b675d9ed3ee36f5606231cea31490b2/src/main/java/nourl/mythicmetals/blocks/BlockSet.java#L96-L101 Adding another line here to simply add it to the item tag would probably be the better solution

Noaaan commented 9 months ago

Superseded by dd376c2eaeb886ec4c59ca184e8a800b508ea1ca. Thanks for the contribution either way!