Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
73 stars 26 forks source link

Tag datagen: update raw ores; add dusts + nuggets #243

Closed unilock closed 3 weeks ago

unilock commented 4 weeks ago

This PR mainly updates MythicItemDataProvider:

ItemSet has been updated as well, as tag injection for nuggets is no longer necessary.

This fully fixes #183.

Noaaan commented 4 weeks ago

If I recall correctly I did squash some bugs related to datagen when porting. Multiple entries of the same tag while tag nesting are functional, but technically incorrect (ugly). It happens since there is no collision checks during the datagen (correct handling is only adding it once). I am slightly worried with nesting mythicmetals:dusts within c:dusts. Does this not throw a warning if the former is empty? (Which could happen if disabled)

unilock commented 4 weeks ago

I am slightly worried with nesting mythicmetals:dusts within c:dusts. Does this not throw a warning if the former is empty? (Which could happen if disabled)

It does not. #mythicmetals:dusts can still be referenced in-game (e.g. in REI's "tag viewer" category), but is simply empty.

Noaaan commented 4 weeks ago

Ok thats great. From a glance it looks fine. Will give a better review ASAP 👍