Closed unilock closed 3 weeks ago
If I recall correctly I did squash some bugs related to datagen when porting. Multiple entries of the same tag while tag nesting are functional, but technically incorrect (ugly). It happens since there is no collision checks during the datagen (correct handling is only adding it once).
I am slightly worried with nesting mythicmetals:dusts
within c:dusts
. Does this not throw a warning if the former is empty? (Which could happen if disabled)
I am slightly worried with nesting
mythicmetals:dusts
withinc:dusts
. Does this not throw a warning if the former is empty? (Which could happen if disabled)
It does not. #mythicmetals:dusts
can still be referenced in-game (e.g. in REI's "tag viewer" category), but is simply empty.
Ok thats great. From a glance it looks fine. Will give a better review ASAP 👍
This PR mainly updates
MythicItemDataProvider
:#mythicmetals:raw_ores
is now added to#c:raw_ores
, just as#mythicmetals:ingots
is added to#c:ingots
#mythicmetals:dusts
is added to#c:dusts
and#mythicmetals:nuggets
is added to#c:nuggets
as wellItemSet
array returned byReflectionUtils
, and they're not registered during datagen for some reason? (unlike all other Dusts and Nuggets)#c:dusts
,#c:nuggets
, and#c:raw_ores
look a little broken, but so does#c:ingots
so I guess it's fine?ItemSet
has been updated as well, as tag injection for nuggets is no longer necessary.This fully fixes #183.