Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
73 stars 26 forks source link

[Fabric 1.20.1] Mythic Metals breaks merling origin swim speed due to shipping newer Additional Entity Attributes #244

Open Mouy07 opened 3 weeks ago

Mouy07 commented 3 weeks ago

Summary When using the latest version of Mythic Metals (0.19.8) with Origins, the merling origin's increased swim speed does not work. Issue is not present in earlier versions.

Version Details Minecraft 1.20.1 Fabric 0.15.11 Mythic Metals 0.19.8 Origins 1.10.0

Expected Behavior When using merling origin, underwater movement speed will be increased to 4.9 m/s while walking and 9.8 m/s while sprinting.

Observed Behavior Merling underwater movement speed is unchanged from default (1.96 m/s walking, 3.92 m/s sprinting).

Noaaan commented 3 weeks ago

This is not directly caused by Mythic Metals. It is caused by the bundled version of Additional Entity Attributes. Currently I ship 1.7.4, while Origins is still built against 1.3.0. I don't think there is a ton I could do to fix this, as the best fix would be for Origins themselves to update that dependency.

Mouy07 commented 3 weeks ago

Ah that makes sense. Thanks!