search

Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
74 stars 24 forks source link

Move DefaultRegistryMixin identifiers to separate class #61

Closed Qendolin closed 2 years ago

Qendolin commented 2 years ago

These identifiers pollute every instance of DefaultedRegistry which are quite a lot. https://github.com/Noaaan/MythicMetals/blob/e1bf9fd4efc800fb16a54fd0671224dc1379bb6a/src/main/java/nourl/mythicmetals/mixin/DefaultedRegistryMixin.java#L17

This does not cause any issues right now but it is very annoying seeing all those fields in my IDE when debugging. Even worse they are not private.

image

Noaaan commented 2 years ago

Should hopefully be fixed in latest commit. If you could try it out I would make a release if it seems good

Qendolin commented 2 years ago

I don't really wanna download the source and setup the project, can you give me a jar?

Noaaan commented 2 years ago

No problem, here you go: mythicmetals-0.11.4.zip

Qendolin commented 2 years ago

Just tried it out, and it's fixed

Noaaan commented 2 years ago

Fixed and released as of 0.11.4