search

Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
74 stars 24 forks source link

Incompatible with Terralith #85

Closed Zekiu closed 2 years ago

Zekiu commented 2 years ago

Everytime I try generating a world with Mythic Metals and Terralith installed the game crashes with "Caused by: java.lang.IllegalStateException: Feature order cycle found, involved sources: [Reference{ResourceKey[minecraft:worldgen/biome / terralith:emerald_peaks]=net.minecraft.class_1959@2fe03aac}]"

latest.log: latest.log

latest crash report: crash-2022-07-04_00.17.39-server.txt

CamperSamu commented 2 years ago

Strange, I use Terralith+ other world generation mods with mythic metals and it doesn't crash

Have you updated Fabric API?

Zekiu commented 2 years ago

yea, I have latest Fabric API, 0.57.0 for 1.19

Zekiu commented 2 years ago

Huh, seems like this issue only happens with the mod version of Terralith, datapack version works fine

Noaaan commented 2 years ago

Its worth noting that the datapack version of latest Terralith is versioned at 2.3.2, while the CurseForge release is at 2.3.1. I am using biome tags for ore generation, but it never mentioms any features in the logs. Is there an oversight that has been fixed here, @Starmute ?

ghost commented 2 years ago

I'm also experiencing this exact issue. The mods might work at first until Emerald Peaks is generated somewhere in the world.

Noaaan commented 2 years ago

Talked with Starmute about it, and this is likely a bug regarding Fabrics new Conventional tags (which i use), and the explicit Terralith compat. The convention tags automatically add vanilla tags to themselves, which is something that Terralith uses. Because of this, Osmium is added twice to a bunch of the mountainous regions, causing a feature order cycle.

SteveNichols5 commented 2 years ago

So not to be a pain but do we know which dev is going to be the one to fix this? Is it a Fabric fix, a Mythic Metals fix, or a Terralith fix?

Noaaan commented 2 years ago

This is on my side, do i will fix it