Open Noah-Huppert opened 3 years ago
The only possible problem with running the setup.sh
script in the cloned down version of this repository is that it breaks the pattern of always using the version of a script which was invoked. This pattern is relied on when tweaking the installation scripts. As you can make local changes and run the script, without having to refer back to the repository.
Maybe since Salt will be installing states which are cloned down from GitHub this pattern ends right at this point in the installation process. Since we stop referring to what is in the ISO and to what is in Git.
Now the
setup.sh
script inlive-scripts
relies on other scripts like the one to create salt symlinks. So theinstall.sh
script copying just thesetup.sh
script into the chroot and running it will not do anymore. Should probably use the cloned down version of the repository within the chroot and just run in there, since all the dependency scripts will already be setup and ready to go.Also having an issue where
user
is not defined in the pillars whensetup.sh
is run (after manually working around the issue prev. described).