NoahGWood
commented
1 year ago L168 should be YYYY L179, I have not implemented support for amputated fingers, that's going to require more digging into the standards and possibly a rewrite as I have to also generate fields in the Type2 record. L180 is your state ID/drivers license
L292 is for testing/development.
In Python anything in the if __name__ in '__main__': block is only executed when a script is called directly, so if you used ./eft_helper.py, the code would execute, but if you import eft_helper as a module it won't be executed.
As far as GUI's go, I'm thinking it'd be best to go with a webapp, possibly writing the backend in flask and embedding chromium so it just works
Is this supposed to be
YYorYYYY? https://github.com/NoahGWood/OpenEFT/blob/main/core/eft_helper.py#L168What needs to be fixed here? https://github.com/NoahGWood/OpenEFT/blob/main/core/eft_helper.py#L179 Is this a bug, or more like a person has a missing finger so that print is unavailable?
Is State ID the two letter state code? (If so, apparent duplication) https://github.com/NoahGWood/OpenEFT/blob/main/core/eft_helper.py#L180
Should this be the output argument? https://github.com/NoahGWood/OpenEFT/blob/main/core/eft_helper.py#L292
self.src = ORI? https://github.com/NoahGWood/OpenEFT/blob/main/core/eft_helper.py#L215I can work on making some of these changes. But want to confirm first. I can also work on wrapping this with tkinter then you'd have a nice distributable package, something people would be more comfortable with.