search

NoahTheDuke / vim-just

Vim Just Syntax
MIT License
85 stars 8 forks source link

Upcoming Ubuntu 24.04 runner may not have Clippy pre-installed #103

Open laniakea64 opened 1 month ago

laniakea64 commented 1 month ago

In https://github.com/NoahTheDuke/vim-just/issues/78 / https://github.com/NoahTheDuke/vim-just/commit/53459ce5cc358ad3844f3ee5ac57ec3e4e3097b5 we removed the "Install Rust Toolchain Components" step, because it's redundant in the current CI runner image. But according to documentation of upcoming Ubuntu 24.04 runner and https://github.com/actions/runner-images/issues/9848 , looks like Clippy will no longer be pre-installed in our CI when that runner image becomes ubuntu-latest. Which https://github.com/actions/runner-images/issues/9848#issuecomment-2111684278 suggests will likely happen sometime next month.

We need to either reinstate use of rustup for Clippy or temporarily pin our CI to ubuntu-22.04.

laniakea64 commented 1 month ago

temporarily pin our CI to ubuntu-22.04.

I'm inclined to go this route:

1) Clippy is far from the only software listed as "Removed from the Ubuntu 24.04 image due to maintenance reasons." With that much software removed for that same reason, it's not immediately clear how many of these removals are expected to be permanent. Maybe wise to delay the switch to Ubuntu 24.04 to see if Clippy might be reinstated later?

2) Switching on our own schedule means we can be sure to adapt to changes at the time of switching and avoid a period of broken CI.

3) Ubuntu 22.04 has Vim 8.2.3995 while Ubuntu 24.04 has Vim 9.1.0016. 8.2.3995 is closer to our minimum supported Vim version, so CI having that version makes it more likely to catch issues.

laniakea64 commented 1 month ago

Went ahead with pinning CI to ubuntu-22.04 today to get rid of the urgency.

@NoahTheDuke Anything else to consider/address here, or close this?