search

NobelD / NobleWhitelist

A simple whitelist management plugin including uuid, name and bypass access.
MIT License
7 stars 2 forks source link

[Feature Request] Plugin localization and replace minecraft:whitelist command #7

Open marat2509 opened 3 months ago

marat2509 commented 3 months ago

Hello.

Thank you for this plugin ❤️

I request you to add the following functionality to your plugin:

  1. localization (at least command messages)

I would like to be able to receive commands messages in native language (which will be added by community members). I for example am ready to add Russian language if you will implement this functionality

  1. Possibility to replace the standard /whitelist command (and possibly disable Minecraft's built-in whitelist mechanism). It is expected to be possible to include in config.yaml to replace the standard /whitelist command with the functionality of the /nwl command. Better yet, implement it in the alias column for the noblewhitelist command.

Example of new settings in config.yml:


command:
  aliases:
    - "wl"         # /wl        -> /noblewhitelist
    - "whitelist"  # /whitelist -> /noblewhitelist

  disable-minecraft-whitelist: true
  # disables /minecraft:whitelist commands and default minecraft whitelist functional

Thank you for your contribution to the open source community ❤️

NobelD commented 3 months ago

hi, thanks for the comment!

the localization is almost "implemented" in the dev version, I just didn't make an announcement about it yet for those who want to contribute with it, I hope I don't forget it, when it's ready I'll leave another comment with it if you want to help before the release of the next version ^^

and disabling or replacing the vanilla whitelist command is a good idea, I'll just look for a proper way to prevent users from getting confused or breaking the plugin with it lmao I'll add it to the list of features to be implemented thanks again!!! 🐈

marat2509 commented 3 months ago

the localization is almost "implemented" in the dev version, I just didn't make an announcement about it yet for those who want to contribute with it, I hope I don't forget it, when it's ready I'll leave another comment with it if you want to help before the release of the next version ^^

How to localize into another language? It was expected that there would be a certain folder with localization json files, which would be unpacked into the plugin folder, the language would be specified in the config, and the plugin would already accordingly, use strings for the desired localization, replacing placeholders with the necessary variable values.

NobelD commented 3 months ago

Yeah, that's done, just waiting to finish the other things for the update, so no more messages need to be added!