search

Nobelz / RateMyProfessorAPI

Python web scraper to get professor ratings from ratemyprofessor.com website.
Apache License 2.0
39 stars 11 forks source link

Update comment field of Professor #1

Closed ozeitis closed 3 years ago

ozeitis commented 3 years ago

Currently, comments from the rating class return comments with horribly formatted HTML special characters, these changes will fix that.

ozeitis commented 3 years ago

Apologies, I was traveling. I have done what you have asked. I hope to try to add more meaningful edits to this as a major project I am making is highly reliant on this. Very much appreciate all this work! I am a 1st year Comp Sci student so trying to get some projects under my belt :)

Nobelz commented 3 years ago

Apologies, I was traveling. I have done what you have asked. I hope to try to add more meaningful edits to this as a major project I am making is highly reliant on this. Very much appreciate all this work! I am a 1st year Comp Sci student so trying to get some projects under my belt :)

No worries, I am a 2nd year Comp Sci student so I am very new to this as well, as you may be able to tell :) I'm honored that you've chosen to use this API and hopefully it will get better over time as more experienced people teach me the methods to maintain this repo.

As for your latest changes, thank you for merging the pull request, however it still fails to pass the checks because of some issue with lxml, I'm going to try importing lxml and see if that solves the problem.

EDIT: This is the error I'm getting:

======================================================================
ERROR: test_ratings (tests.test.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/RateMyProfessorAPI/RateMyProfessorAPI/tests/test.py", line 79, in test_ratings
    ratings = connamacher.get_ratings()
  File "/home/runner/work/RateMyProfessorAPI/RateMyProfessorAPI/ratemyprofessor/professor.py", line 134, in get_ratings
    ratings.append(Rating(rating=rating["helpfulRating"], difficulty=rating["difficultyRating"],
  File "/home/runner/work/RateMyProfessorAPI/RateMyProfessorAPI/ratemyprofessor/professor.py", line 195, in __init__
    self.comment = BeautifulSoup(comment, "lxml").text
  File "/opt/hostedtoolcache/Python/3.9.6/x64/lib/python3.9/site-packages/bs4/__init__.py", line 243, in __init__
    raise FeatureNotFound(
bs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: lxml. Do you need to install a parser library?

----------------------------------------------------------------------
Ran 3 tests in 3.876s
Nobelz commented 3 years ago

I have merged your pull request for the time being, as it now passes all preliminary checks. Before releasing v1.3.0, however, I will perform additional checks to ensure that it works as intended. Thanks. -Nobel

Nobelz commented 3 years ago

Your changes are now reflected in Release v1.3.0. Thanks for your contributions!