search

Nobelz / RateMyProfessorAPI

Python web scraper to get professor ratings from ratemyprofessor.com website.
Apache License 2.0
39 stars 11 forks source link

Doesn't work #7

Closed samemon closed 1 year ago

samemon commented 2 years ago

The calls return None for valid examples. Any update?

Nobelz commented 2 years ago

At the moment, this API is not maintained on a regular basis. However, could you provide an example where it doesn't work?

glenviewjeff commented 2 years ago

The example you provided on the main project page isn't working (Python 3.9.15 and 3.8.10.) Apparently get_school_by_name is returning "none" regardless of the school. I tried multiple schools.

image

ChrisBryann commented 1 year ago

It seems RateMyProfessors.com updated their website. This code: data = re.findall(r'/campusRatings\.jsp\?sid=(\d+)', page.text) from initpy on line 55 causes data to be None. This is because the website doesn't have any link that has those criteria.

ChrisBryann commented 1 year ago

I could try to work on fixing this if you are okay with it.

glenviewjeff commented 1 year ago

Please do! Thanks

ChrisBryann commented 1 year ago

@Nobelz Hi, I forked your repository and made fixes. I requested a pull request and please do a sanity check on it. Thanks.

Nobelz commented 1 year ago

v.1.3.3. Let me know if there are any problems.