search

NobilityDeviant / Wcofun.com_Downloader

A java & Kotlin cartoon and anime downloader for https://www.wcofun.com/
26 stars 3 forks source link

Brave support? #12

Open ripnonfegames opened 1 year ago

ripnonfegames commented 1 year ago

It's chromium, shouldnt selecting chrome support it too? It's not working for me.

ego-lay-atman-bay commented 1 year ago

I'm with you on this. I prefer to use brave, especially since it has an adblocker. I think the best solution would be to allow the user to put in a custom browser location, and also specify the type of browser, e.g. chromium, firefox, or safari (most browsers use either chromium or firefox).

NobilityDeviant commented 1 year ago

It's chromium, shouldnt selecting chrome support it too? It's not working for me.

Sorry for the big delay. Brave will not be supported because I don't control the library used for driver handling. Please submit an issue here: https://github.com/bonigarcia/webdrivermanager asking for Brave support. If it is added, I will add an option.

The Chromium option is used for the actual chromium browser mostly found on linux.

NobilityDeviant commented 1 year ago

I'm with you on this. I prefer to use brave, especially since it has an adblocker. I think the best solution would be to allow the user to put in a custom browser location, and also specify the type of browser, e.g. chromium, firefox, or safari (most browsers use either chromium or firefox).

Adblocker on a browser is not one of my goals even with extensions. I could add an adblock extension to chrome, but there is no point. You never see the ads anyways because the browser is headless. This to support the creator of the website and to avoid any "Adblock Detection" issues. Fair to say that is could potentially speed up the process and save a bit of bandwidth, but they will most likely detect the adblocker and not load the video which is a problem.

If there would be any browser i'd love added, it would be Vivaldi. They do have an adblocker that isn't detected by modern adblock detectors if only blocking trackers. https://prnt.sc/oCin1sORPqv6

ego-lay-atman-bay commented 1 year ago

I actually wrote that before I actually tested the program. Now I don't mind not having adblocker, because it doesn't show the page. The big reason why I want to use brave now is because it blocks google tracking.

Edit: here's my issue on webdrivemanager https://github.com/bonigarcia/webdrivermanager/issues/1096#issue-1848676727