Run unit tests on macOS with M1 support

Noble-Lab / casanovo

De Novo Mass Spectrometry Peptide Sequencing with a Transformer Model

https://casanovo.readthedocs.io

Apache License 2.0

102 stars 37 forks source link

Run unit tests on macOS with M1 support #301

Closed bittremieux closed 4 months ago

bittremieux commented 7 months ago

See here for the available (free) runners for GitHub Actions.

bittremieux commented 7 months ago

It does seem like we're immediately running into MPS-related errors. @wfondrie is this something you can easily diagnose?

bittremieux commented 7 months ago

I tried to set PYTPYTORCH_MPS_HIGH_WATERMARK_RATIO=0.0, as suggested by the error message, but that didn't solve the issue. There are (conflicting) reports here that this issue might get solved in PyTorch 2.3, which is scheduled for release in April.

As a non-macOS user and lacking familiarity with this error, I currently don't see many other options than to wait until then.

bittremieux commented 4 months ago

Apparently MPS is not actually available for the GitHub Action runners, so there's no way to test this currently. #327 has disabled running on M1/M2 chips (which will automatically try to use MPS), so at least our tests don't fail anymore.