search

Noble-Lab / casanovo

De Novo Mass Spectrometry Peptide Sequencing with a Transformer Model
https://casanovo.readthedocs.io
Apache License 2.0
90 stars 31 forks source link

Allow csv to handle all newlines #316

Closed mobiusklein closed 3 months ago

mobiusklein commented 3 months ago

The csv module tries to handle newlines itself. On Windows, this leads to line endings of \r\r\n instead of \r\n.

Setting newline='' produces the intended output on both platforms.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.77%. Comparing base (6eabd6e) to head (8693b51).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #316 +/- ## ======================================= Coverage 89.77% 89.77% ======================================= Files 12 12 Lines 929 929 ======================================= Hits 834 834 Misses 95 95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mobiusklein commented 3 months ago

Thank you. I see that the base branch issue was a bigger mess than I expected. I'll make sure to use the dev branch in the future.

bittremieux commented 3 months ago

No problem. It's not documented in our contributing guidelines, so there was no way for you to know. We should update the CONTRIBUTING.md to reflect this.