search

Noblis / INVSC-janice

An open API for computer vision algorithms
https://noblis.github.io/janice/
Other
9 stars 4 forks source link

Is JaniceMediaIterators intentionally being passed by value? #18

Closed taa01776 closed 6 years ago

taa01776 commented 6 years ago

All of the APIs that take a JaniceMediaIterators parameter (janice>cluster_media, janice_detect_batch, janice_fine_tune, janice_enroll_from_media_batch) have JaniceMediaIterators media in their argument list. Which seems like it should be a pointer, but it's not--the parameter is being passed as a struct. Is this right?

JordanCheney commented 6 years ago

It can be passed as a const pointer (it shouldn't be modified in any of the functions) instead of being passed by value. This form is consistent with how the API passes all of the fully defined stucts (JaniceRect, JaniceTrack etc.).

JordanCheney commented 6 years ago

Discussion on this has moved to #26