search

Noction / vue-draggable-grid

https://noction.github.io/vue-draggable-grid/
93 stars 34 forks source link

fix: distinction between update:layout and layout-updated events #12

Closed schuhwerk closed 1 year ago

schuhwerk commented 2 years ago

Hi! Thanks for your great work!

I just updated this PR with your most recent changes (and cleaned things that did not belong in here).

I came across the issue, that you don't make a distinction between an ongoing layout change and a finished one here. In both cases the update:layout event is emitted.

So I gave the second one (in the highlighted lines) a different name and based the naming of the finished event (layout-updated) on the implementation of jbaysolutions.

I'm not sure why they used different notations ( "-" vs ":" )... What do you think?

LwveMike commented 1 year ago

Thank you for your contribution.

LwveMike commented 1 year ago

About ':' vs '-', this will be revised in the future, when we'll refactor a lot of this module, and also add proper types.