Closed jremi closed 8 months ago
Now the branch main
is used for release and the branch next
is used for pre-release.
Hi guys, I just opened a PR for this bugfix: https://github.com/Noction/vue-draggable-grid/pull/52
🙏
Merged pull request, now present in v1.9.16
Tested on release
<= v1.9.15
.GridLayout.vue: L195 exposes array
layoutItemOptionalKeys
. However its missing several optional grid item properties (isBounded
,dragIgnoreFrom
,dragAllowFrom
,resizeIgnoreFrom
,preserveAspectRatio
,dragOption
,resizeOption
).Without these included the props do not get passed down into the GridItem.vue.
You can easily test this with for example adding the optional property
dragIgnoreFrom
to one of your layout grid items. For exampledragIgnoreFrom: '.no-drag'
... Then set a class on an element<div class="no-drag">
. You will be able to continue dragging the element. This should not be possible since you have includeddragIgnoreFrom
property on the grid item.https://github.com/Noction/vue-draggable-grid/blob/07332cb987d44ea87fe942a304c1bf85fc415e59/packages/vue-draggable-grid/src/components/GridLayout/GridLayout.vue#L195
I would have opened a pull-request, however I'm confused why the main branch on your repo is now
1.10.0-beta.4
. I would have expected that beta code be maintained on the next branch.My hope is someone can make a version bump for e.g:
v1.9.16
with the updatedlayoutItemOptionalKeys
array that I have referenced above.🙏