search

Node-SMB / marsaud-smb2

SMB2 Client
53 stars 46 forks source link

Added readdirextra to expose raw file properties #13

Open KanoYugoro opened 8 years ago

KanoYugoro commented 8 years ago

Was not sure about the naming convention for this particular function, but I have a great need to read particular file properties on individual files without loading the entire file into memory. I added a new function so as not to break backwards compatibility of this package. I did not add any logic to parse these individual file properties, as I know things like times and dates are stored differently or mean different things between operating systems.

If there is anything else you need me to do with this branch, or have suggestions on how to better go about what I am trying to achieve, please let me know. Thank you!

andhernand commented 8 years ago

👍

tmccleve commented 8 years ago

👍

julien-f commented 8 years ago

@andhernand @tmccleve https://github.com/blog/2119-add-reactions-to-pull-requests-issues-and-comments :smiley:

KanoYugoro commented 8 years ago

@marsaud Is there any chance I could get this pulled in?

KanoYugoro commented 8 years ago

@marsaud Just checking in again. Any chance to look at this? I can fork and publish my own version of this if you can't be bothered to maintain it.

olivierlambert commented 8 years ago

@marsaud can you take a look at this and evaluate the "risk" to merge it? @KanoYugoro we'll check this soon!