Update base - Githubissues

tracker1 commented 6 years ago

Curious if you might consider updating the base requirement to node 8.x?

In this way you can eliminate bluebird and babel from the build and dependency chain... also makes testing against the source easier. I'm willing to put in the effort and submit a PR.

Note: was going to do this anyway, I'm diagnosing an issue I'm seeing regarding permissions error with ensureDir. But would rather submit a PR instead of publishing another name-spaced fork.

marsaud commented 6 years ago

Yes, go on.

I'll pick up this opportunity to review all opened PRs and then keep a closer eye on this repo.

tracker1 commented 6 years ago

I've forked downstream from dcyou fork... https://github.com/tracker1/node-smb2

moved the lib/api/src to lib/api and updated the require and exports to match cjs (for now)
tweaked the paths so that unix separators can be used
added support for url string for share/options
made api interfaces isomorphic returning promises, making callback optional but still supported, no need for separate -promise version
set engine to node >= 8.5, since iirc that's when async functions are available without a flag.

Need to investigate some issues, as I'm getting ACCESS_DENIED when trying to test for my own use... authentication seems to work okay though.

I can create a branch that has an appropriate package.json, and README.md attached, for direct merge/PR ... not much logic has changed so far. I've tried to bring in various fixes/adjustments from a few of the forks.

tracker1 commented 6 years ago

@marsaud @julien-f Looks like with the recent adjustments, I think the only thing I added in my fork not here is the support for an smb:// url string, and normalizing paths... Going to create 2 separate issues for these. :-)

julien-f commented 6 years ago

Thanks!

tracker1 commented 6 years ago

Actually, looks like the build process is still in place (with a few tweaks, unnecessary for modern node versions)... will try to create a branch this weekend for just that part...

julien-f commented 6 years ago

The build process is still here only for ensureDir which I did not have the time to rewrite in ES5 yet, as soon as it's done we'll be able to remove it :slightly_smiling_face:

tracker1 commented 6 years ago

Should be able to just rewrite the import/export statements and remove/replace Bluebird with internal Promises. :-) Cool, all the same. Nice to see complexity come out.

Node-SMB / marsaud-smb2

Update base #22