fix(createReadStream): implement backpressure

Node-SMB / marsaud-smb2

SMB2 Client

53 stars 46 forks source link

fix(createReadStream): implement backpressure #76

Open vdiez opened 3 years ago

vdiez commented 3 years ago

continue reading until stream.push returns false, as specified by streams API

I was running into race conditions where streams were being closed twice on end (instead of just once). Implementing the backpressure from Node solved the issue.

vdiez commented 3 years ago

Hi @julien-f . Any option to have this merged? Thanks!

ekoeryanto commented 2 years ago

same with createWriteStream