search

Node-Virtualization / node-virtualbox

A JavaScript Library for Interacting with VirtualBox
MIT License
259 stars 68 forks source link

Code tooling changes #59

Closed colonelpopcorn closed 4 years ago

colonelpopcorn commented 5 years ago

I wanted to ask the folks here if they would be interested in moving the codebase to Typescript. This would buy us a pre-runtime type check in addition to the linting already available. I also wanted to ask if this is viable with the current Node version (0.12 and newer, from travis.yml file, not sure if accurate 🤷‍♂️) we are targeting.

I would also like to set up some unit and integration tests for the API before I start making many more changes. I'm going to install mocha, chai, and sinon as tools to help out. Is that cool with everyone here?

michaelsanford commented 5 years ago

💯 👍 👏 ❤️

That's my opinion on the matter.

colonelpopcorn commented 5 years ago

I've got a build running (finally), but I need to do some more testing. The build doesn't work with node versions 6 and below, and there will be a few breaking API changes that we should probably discuss.

michaelsanford commented 5 years ago

That's awesome, @colonelpopcorn !

As far as the build not working on 6, I think it's completely fine for it to work only on node latest, or a few versions behind.

In any event, if it affects downstream users, we just release it as a major-breaking-change version (or a milestone) and protect older users from disaster while still moving forward.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not received any attention in 90 days. It will be closed in 14 days if no further activity occurs. Thank you for your contribution! (I'm a bot.)

colonelpopcorn commented 5 years ago

Still working on this, I've been investing time in getting a good integration suite setup.

michaelsanford commented 5 years ago

@colonelpopcorn Awesome!

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not received any attention in 90 days. It will be closed in 14 days if no further activity occurs. Thank you for your contribution! (I'm a bot.)

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not received any attention in 90 days. It will be closed in 14 days if no further activity occurs. Thank you for your contribution! (I'm a bot.)

stale[bot] commented 4 years ago

This issue has been automatically closed due to inactivity. (I'm a bot.)