search

NodeBB-Community / nodebb-plugin-adsense

adsense plugin
BSD 2-Clause "Simplified" License
10 stars 6 forks source link

Is it compatible with 0.9.4? #9

Closed Nisthar closed 6 years ago

Nisthar commented 8 years ago

I enabled nodebb-plugin-adsense. But i can't find the plugin in the plugin section (section where i can download/install plugin). Also even after removing the plugin, I can't find the plugin in the download section. Isn't it compatible with 0.9.4 version?

ornithes commented 8 years ago

git clone https://github.com/NodeBB-Community/nodebb-plugin-adsense.git

yariplus commented 8 years ago

It should be on the downloads page. How did you enable it if you can't find it in the downloads page?

I installed it on 0.9.4 from the downloads page and it seems to work fine. Perhaps something else went wrong. Maybe try resetting it from the command line ./nodebb reset -p nodebb-plugin-adsense

Nisthar commented 8 years ago

I was able to see it in the download section. But i didn't set the plugin settings for 2 or 3 days. Now its giving a blank page when i click on it and its not appearing in the plugins section.

Nisthar commented 8 years ago

I removed it using ./nodebb reset nodebb-plugin-adsense and npm remove nodebb-plugin-adsense

yariplus commented 8 years ago

idk, make sure the directory /nodebb/node_modules/nodebb-plugin-adsense is actually removed. npm remove won't remove git repos. Also, make sure you are using the -p flag on your reset command. ./nodebb reset -p nodebb-plugin-adsense Try cloning it in the /nodebb/node_modules directory if it still doesn't work, as @pikshub says.

Nisthar commented 8 years ago

@yariplus Yes. I did used the -p flag. I'll check if there is a folder in npm modules.

Nisthar commented 8 years ago

@yariplus Yes. There is nodebb-plugin-adsense folder in node_modules folder

Nisthar commented 8 years ago

@yariplus BTW could you provide more info on how to install it using git clone. Do i need to stop nodebb before adding it. Because, I am hosting my app on openshift and had a lot of issues for small mistakes.

yariplus commented 8 years ago

Go to your local /nodebb/node_modules folder, delete the nodebb-plugin-adsense folder. Run git clone https://github.com/NodeBB-Community/nodebb-plugin-adsense.git Push the changes to your app.

Nisthar commented 8 years ago

@yariplus I want to run git clone in the node_modules directory. Right?

Nisthar commented 8 years ago

Ok. Ran it in node_modules folder. Let me check if i can run it.

Nisthar commented 8 years ago

Still the same. Can't find the plugin after reloading the nodebb app http://i.imgur.com/pvo4uzl.jpg

Nisthar commented 8 years ago

@barisusakli Any updates?

barisusakli commented 8 years ago

This plugin should be compatible with 1.0.0 it just needs to be republished to npm with a correct compat string. I will publish it tomorrow.

Why is your installed plugins list empty? It should at least have the default plugins there.

Nisthar commented 8 years ago

@barisusakli Yes. It has the default plugins there. But i can't find the adsense plugin in the downloadable list even after uninstalling. I uninstalled manually with the commands ./nodebb reset -p nodebb-plugin-adsense and npm remove nodebb-plugin-adsense. At first, I was able to see the plugin and download it, But i don't know what went wrong.

This plugin is a must for nodebb applications. Waiting for the fix.

yariplus commented 8 years ago

Not an expert on openshift, but is the problem possibly that the .gitignore file is not pushing the node_modules folder to your app?

Nisthar commented 8 years ago

@yariplus No, I have all the plugins like composer-default and other third-party plugins like imgur, etc. I also had adsense in the downloadable list. I downloaded it, left it untouched for 2 or 3 days. Now when i tried to access the acp page, It give me a blank white page with title Google Adsense. I tried to uninstall it from the admin page. But i was not able to find it in the installed plugins list.

I thought it may be due to recent changes in nodebb or the plugin.

barisusakli commented 8 years ago

I published the 1.0.0 compatible version to npm now.

Nisthar commented 8 years ago

@barisusakli Wow. Thanks :+1:

Can i find it in the acp downloadable plugin section?

barisusakli commented 8 years ago

It should show up in about an hour.

Nisthar commented 8 years ago

Thanks. Will post here my results.

Nisthar commented 8 years ago

@barisusakli Sorry, I can't see it under the download plugin section.

I tried git clone https://github.com/NodeBB-Community/nodebb-plugin-adsense.git But I can't get the plugin to show in my ACP.

Nisthar commented 8 years ago

@barisusakli Ok. I can see it in 1.x.x version. But not in 0.9.4 version.

Nisthar commented 8 years ago

@barisusakli Its working in my localhost version of 1.0.0. But not in 0.9.4 version.

Nisthar commented 8 years ago

I am new to nodebb plugin development. But i see the id of the plugin is different from the id in package.json.