NodeBB-Community / nodebb-plugin-composer-redactor

Redactor Composer for NodeBB
GNU General Public License v3.0
38 stars 28 forks source link

add server side html sanitizing #6

Closed philburr closed 9 years ago

philburr commented 9 years ago

Fixes issue #5

julianlam commented 9 years ago

Thanks @philburr :smile:

drewdotpro commented 9 years ago

For the less file, that gets updated by the redactor team without version control. It might make more sense for these changes to be in a separate file that can be loaded in over the top to override it.

Bitti09 commented 9 years ago

I'm getting the following error after applying this pull request:

31/7 12:14 [13518] - error: /admin/plugins/composer-redactor TypeError: Object # has no method 'checkCompatibility' at Controllers.renderAdminPage (.../node/node_modules/nodebb-plugin-composer-redactor/lib/controllers.js:8:11) at Layer.handle as handle_request at next (.../node/node_modules/express/lib/router/route.js:131:13) at /.../node/src/middleware/admin.js:51:3 at /.../node/node_modules/async/lib/async.js:589:17 at done (/.../node/node_modules/async/lib/async.js:132:19) at /.../node/node_modules/async/lib/async.js:32:16 at /.../node/node_modules/async/lib/async.js:586:21 at /.../node/src/controllers/api.js:19:5 at /.../node/src/plugins/hooks.js:96:4

philburr commented 9 years ago

@Bitti09 Were you not getting the problem before the patch? I'm not getting the problem when I go to the Redactor admin page.

philburr commented 9 years ago

@drewdotpro I'm not terribly familiar with how the less stuff works. Alternatively we could lower the z-index of .composer from 10000 to 1000. I wasn't sure how this would impact other things. If you merge, let's skip the z-index patch for now until a better solution is done.

julianlam commented 9 years ago

To my knowledge, the composer only needs to have a z index lower than the taskbar.

drewdotpro commented 9 years ago

@Bitti09 I also had no trouble. Merged in changes, rolled back 'less file' changes, added them in an override file. Thanks @philburr