NodeBB-Community / nodebb-plugin-composer-redactor

Redactor Composer for NodeBB
GNU General Public License v3.0
38 stars 28 forks source link

Composer window sizing doesn't work as expected #62

Closed Pilvinen closed 7 years ago

Pilvinen commented 7 years ago

It looks like this: Which is not normal. When I start typing it stretches as I type. Scrolling doesn't work.

frndxyz commented 7 years ago

you can fix it by replacing this line in : "nodebb-plugin-composer-default/static/lib/composer/resize.js" $window.trigger('action:composer.resize', { containerHeight : postContainer.height() - 120 });

though its not a proper solution, but scrolling works and editor resize when you put content inside.

julianlam commented 7 years ago

Can you reproduce @pitaj?

pitaj commented 7 years ago

What browser?

Also, what version of this plugin and NodeBB?

pitaj commented 7 years ago

Unable to repro in FF or Chrome

frndxyz commented 7 years ago

@pitaj NodeBB V1.4.2, plugin version : 1.4.15

pitaj commented 7 years ago

Try ./nodebb stop && ./nodebb build && ./nodebb start

frndxyz commented 7 years ago

@pitaj it doesn't seems to fix the issue.

julianlam commented 7 years ago

Actually, should be resolved with latest commit to this plugin.

Pilvinen commented 7 years ago

You can test it at my forum here: https://foorumit.maailmanloppu.fi

Pilvinen commented 7 years ago

I'm still having this issue with Nodebb v1.4.2, Redactor v2.0.1, Chrome 52.0.2743.82 (64-bit). But I highly doubt that it would be browser specific since all my forums users are having the same problem.

https://foorumit.maailmanloppu.fi

julianlam commented 7 years ago

Plugin version?

Pilvinen commented 7 years ago

Like I said above Redactor v2.0.1

pitaj commented 7 years ago

This should be fixed in the latest version. Try updating to v2.0.3

Pilvinen commented 7 years ago

Unfortunately this does not seem to be the case.

1) Updated to v2.0.3. 2) Shut down and restarted Nodebb just to be on the safe side. 3) Still the same issues.

Screenshot:

pitaj commented 7 years ago

Did you try the ./nodebb build thing I suggested before?

Pilvinen commented 7 years ago

Yes. It didn't work. But I tried again and did git pull even though there should be no updates and after that ran ./nodebb build again and that did the trick.

It seems to work now. Thank you.