NodeBB-Community / nodebb-plugin-emoji-extended

Adds extended functionality of Emoji into NodeBB
MIT License
4 stars 1 forks source link

Compatible with 0.9.4 version? #10

Open Nisthar opened 8 years ago

Nisthar commented 8 years ago

I can't get to install the emoji extended 1.0.0 for my 0.9.4 version. So i can't use any other emoji sets.

ghost commented 8 years ago

This is why it's ^1.0.0 compatibility stated. I'm not going to add backwards-compatibility to older versions; If anyone makes a PR for this I'd merge it of course, but I won't spend any time on this. Sorry.

rbeer commented 8 years ago

Will look into it, tomorrow. :smiley:

@frissdiegurke You mind me opening a branch (0.9-comp) for that? So you can simply merge if satisfied.

ghost commented 8 years ago

@rbeer A new branch would be great ;-) Thanks.

rbeer commented 8 years ago

@frissdiegurke Well, call me BoilerplateBeer, but - uuh - what exactly am I supposed to do with that grunt stuff? I don't get it. :/

I'll keep playing with it, but as I'm on one of those 5-10kb/s mobile connections, atm, every npm install really is a pain in the a\ (taking up to 10 minutes, if it doesn't fail all together 'cause some shasum failure -.- ).

ghost commented 8 years ago

@rbeer

  1. clone nodebb-grunt
  2. create a file nodebb-grunt/modules/emoji-extended.json like
{
  "type": "plugin-babel",
  "aliases": ["ee"]
}
  1. clone nodebb-plugin-emoji-extended into nodebb-grunt/modules/plugins/emoji-extended
  2. ensure npm i -g grunt-cli is installed
  3. run npm i && npm i grunt-contrib-jshint grunt-babel babel-preset-es2015 grunt-contrib-less grunt-contrib-uglify && grunt config (within nodebb-grunt/) to initialize the environment
  4. You can now run ./g ee d (within nodebb-grunt/) and start development (see file comments for other shortcuts)

o_O it's simple like that O_o

Git branching etc. needs to be done by hand :stuck_out_tongue_winking_eye:

EDIT: forgot about writing the necessary optional dependencies for this plugin; corrected

ghost commented 8 years ago

PS: the babel-compilation does only happen for publish/deploy commands, so you need an ES2015 compatible node.js running for development. Otherwise investigate the config/compilation/sets/babel.json file

rbeer commented 8 years ago

Thank you! Got it to work, now. Although I'm using the build:module to test. What is dev:module for? It starts a dev instance, compiles to .tmp, but there's no linking going on. Why would I need the compilation in .tmp when NodeBB doesn't see any of it?

EDIT: Maybe I should elaborate what my workflow has been, so far. I get the feeling I just don't understand yours, or the one using grunt-tasks.

Folder structure:

Plugin folders are symlinked to node_modules in each Nodebb version folder.

Then I got a dev instance running, simply sending it a SIGHUP to restart, when I want to test changes made to a plugin.

ghost commented 8 years ago

@rbeer On both tasks it copies the files from .tmp into NodeBB/node_modules. The differences are the compilation steps (dist uglifies & babel-transpiles for example) and that dev starts a blocking file watcher.

rbeer commented 8 years ago

:laughing: I just saw it!

Running "clean:active" (clean) task
Warning: Cannot delete files outside the current working directory. Use --force to continue.
Aborted due to warnings.

But the dev instance invoked by ./g keeps running, that threw me off. Sorry :)

Should the nodebb folder be a subdir of nodebb-grunt?

ghost commented 8 years ago

Yes, it's supposed to be a subdir of nodebb-grunt.

rbeer commented 8 years ago

Gonna open this up again. Just made the third attempt and still haven't gotten around to write a single line of code. I can't even get the smiley packs to download. Timeouts here, constant sha failures (npm) there, it's a mess all over the place. Not the plugin, mind you. My current connection is simply too bad to work on this, sorry. :weary: