search

NodeBB-Community / nodebb-plugin-shoutbox

NodeBB Shoutbox plugin
MIT License
31 stars 34 forks source link

Error when the shoutbox widget is visible to everyone #66

Closed HarasimowiczKamil closed 10 years ago

HarasimowiczKamil commented 10 years ago

If the widget is visible to all, it will suppress all others for not logged users.

Schamper commented 10 years ago

Could you please explain a bit more?

HarasimowiczKamil commented 10 years ago

If you add shoutbox widget to widget zone for example to home.tpl. So, in panel You have like this (shoutbox have this same visibility settings):

If you logged is good

But if I not: :( you will not see any widget.

I turn off widgets one at once and this is shoutbox fault.

Schamper commented 10 years ago

Currently the shoutbox is always hidden for anonymous users. I don't quite remember the exact reason for this, but I'm sure it was something logical.

https://github.com/Schamper/nodebb-plugin-shoutbox/blob/master/library.js#L80

I think because it was easier to do this, than to remove/disable all the logged in futures. Also when I made this, NodeBB didn't have the option to hide widgets for anonymous users.

Edit: I actually think I'm starting to see the issue. The issue is not that the shoutbox is hidden, it's that other widgets are hidden, right? If so, I'll work on a fix whenever I get the time.