NodeBB / NodeBB

Node.js based forum software built for the modern web
https://nodebb.org
GNU General Public License v3.0
14.11k stars 2.78k forks source link

Icon Picker links to fontawesome page with newer version than Nodebb has #9617

Closed skeddles closed 3 years ago

skeddles commented 3 years ago

When you are picking an icon for a category or link, there is this blurb at the bottom:

image

To me this heavily implies you can get more icons by clicking that link. But if you go to that page and find an icon and put the name into the icon picker on nodebb, it doesn't work. You just get a blank icon.

Turns out the list that is linked to is showing icons from FontAwesome5, where nodebb comes with fontawesome4.

This is very confusing to new users.

I suggest you do one of the following:

  1. At the very least, link to the proper set of icons in that list: https://fontawesome.com/v4.7/icons/ (and maybe change the wording so it doesn't sound like there's a bigger list of icons)

  2. Upgrade nodebb to use the newer fontawesome (this would make it easier to find icons)

  3. Make it so admins can easily choose which version of fontawesome to load via settings panel (i know you can upgrade it yourself by editing some server side files, but i dont want to / shouldn't have to do that)

barisusakli commented 3 years ago

I think the reason we are using 4.x is because of licensing. I updated the link to the 4.x icons.

skeddles commented 3 years ago

Thank you, that will at the very least be less confusing to new users.