search

NodeBB / nodebb-plugin-composer-default

Default Composer for NodeBB
MIT License
13 stars 56 forks source link

composer does not follow theme / skin settings #85

Closed geransmith closed 1 year ago

geransmith commented 7 years ago

When using the composer, Persona theme, and attempting to apply a skin, the composer keeps the white look.

I am not sure if this is an issue with the composer, how with the theme not skinning the composer properly. Ultimately I'd like the look and feel to be consistent across the board. If a user has the Cyborg Bootswatch skin on, the composer should have the same dark theme to it.

pitaj commented 7 years ago

Unfortunately this is impossible while supporting user-selectable Bootswatch skins.

geransmith commented 7 years ago

Interesting! I guess we can close this then. Thanks for the quick reply.

barisusakli commented 1 year ago

This is doable, right now composer hardcodes the background to white and doesnt properly handle text colors, thats why it breaks on some skins. Should be fixable by using proper bs variables.

barisusakli commented 1 year ago

cyborg with hardcoded white bg image

cyborg after removing hardcoded white and using bs5 card-body class on the composer container and removing hardcoded color on formatting buttons. image

Just need to go through composer css and remove hardcoded bg/color values.

pitaj commented 1 year ago

Ah yeah because skins are compiled now.