search

NodeFly / uhura

Server-to-server event emitter with session support
MIT License
19 stars 5 forks source link

lib/client: make createConnection callback-driven #10

Closed bnoordhuis closed 10 years ago

bnoordhuis commented 10 years ago

Plus commits that add ref/unref methods to uhura.Client and tidy up the timer unref hack from ef477d1.

Suggested reviewer: @themitchy

slnode commented 10 years ago

Test PASSed. To trigger a build add comment - ".test\W+please" Refer to this link for build results: http://ci.strongloop.com/job/uhura/50/

sam-github commented 10 years ago

LGTM

sam-github commented 10 years ago

But API is incompatible, don't forget to increment version minor in package.json

bnoordhuis commented 10 years ago

Cheers, landed.

But API is incompatible, don't forget to increment version minor in package.json

I don't think that's necessary, createConnection hasn't made its way into a release yet.

bnoordhuis commented 10 years ago

Released as v0.1.1. I also added all missing tags, the only release so far that had a tag was v0.0.7.