search

NodeFly / uhura

Server-to-server event emitter with session support
MIT License
19 stars 5 forks source link

lib/client: unref reconnect timer #9

Closed bnoordhuis closed 10 years ago

bnoordhuis commented 10 years ago

Unref the reconnect timer so it doesn't keep the event loop alive. Fixes a stall at exit in strong-agent.

No regression test, I'm afraid. The particular condition of whether or not the event loop has cleaned out is pretty much impossible to test with mocha.

Suggested reviewers: @themitchy @Qard

slnode commented 10 years ago

Test PASSed. To trigger a build add comment - ".test\W+please" Refer to this link for build results: http://ci.strongloop.com/job/uhura/48/

themitchy commented 10 years ago

LGTM

bnoordhuis commented 10 years ago

Cheers, landed in ef477d1.