search

NodeOS / PalmTree

A service starter for NodeOS.
GNU General Public License v3.0
5 stars 0 forks source link

publish on npm #1

Closed piranna closed 8 years ago

piranna commented 8 years ago

Finally I got time to review and improve it and work like a charm in NodeOS :-) Would you be able to publish a new version on npm?

mitsukaki commented 8 years ago

Will do!

piranna commented 8 years ago

Perfect ;-) We should consider about doing some unit tests, it's a simple program but it would not make any hurt... :-P El 17/2/2016 17:44, "Lite McFish" notifications@github.com escribió:

Closed #1 https://github.com/lite20/PalmTree/issues/1.

— Reply to this email directly or view it on GitHub https://github.com/lite20/PalmTree/issues/1#event-553838655.

mitsukaki commented 8 years ago

I just updated the module. I'll write some mocha tests when I get on my laptop

piranna commented 8 years ago

Cool :-) El 17/2/2016 5:58 PM, "Lite McFish" notifications@github.com escribió:

I just updated the module. I'll write some mocha tests when I get on my laptop

— Reply to this email directly or view it on GitHub https://github.com/lite20/PalmTree/issues/1#issuecomment-185296826.

mitsukaki commented 8 years ago

@piranna I had to 'modulify" PalmTree to make tests work but PalmTree works beautifully. Awaiting nodejs integration.

I should forwarn you, it doesn't reboot applications that close (if you intended for it to do that, it doesn't). Because we spawn everything detached, the program simply terminates when done launching. I hope that was your intended behaviour, else I can adjust it.

I've published the newest version as 2.5.0 on npm.

piranna commented 8 years ago

@piranna I had to 'modulify" PalmTree to make tests work but PalmTree works beautifully.

Have you put some fragments on an inportable module? Good idea :-)

Awaiting nodejs integration.

Do you mean NodeOS? It's working flawlesly there :-) I'll wait until I have working the rewritten nsh (I'm having problems with the stdio streams...) before upload my changes to NodeOS.

I should forwarn you, it doesn't reboot applications that close (if you intended for it to do that, it doesn't). Because we spawn everything detached, the program simply terminates when done launching. I hope that was your intended behaviour, else I can adjust it.

Detached is not the problem, but do I have an .unref() somewhere? This makes parent process to don't wait child one to finish, the same way you are describing. Probably my fault, I'm used to use it. Please fix it, process should be restarted.

I've published the newest version as 2.5.0 on npm.

Ok :-)

mitsukaki commented 8 years ago

.unref()

I was curious as to why you added that haha yes I'll remove it and test again. Mind if I take a peek at NSH to see if I can give you a hand?

mitsukaki commented 8 years ago

Do you mean NodeOS?

Woops! Yeah haha

piranna commented 8 years ago

Mind if I take a peek at NSH to see if I can give you a hand?

I'll upload a new version, but seems to be a dificult bug, launched programs are loosing keystrokes without reason... :-/