NodeOS / nodeos-cross-toolchain

5 stars 6 forks source link

Better OS X Support #25

Closed joshgarde closed 7 years ago

joshgarde commented 7 years ago

Merry (late) Christmas Everyone! 🎄 🎁

Updated OS X support along with other small miscellaneous fixes.

I'll upload the prebuild after this has been reviewed and approved.

joshgarde commented 7 years ago

Travis-ci build: https://travis-ci.org/joshgarde/nodeos-cross-toolchain/builds/186734505

A full "BigRedButton" build on my machine takes ~ 70 minutes so we'll most likely never see a completed Travis-ci build due to the 50 minute timeout, but compiling x86 works fine looking at logs.

piranna commented 7 years ago

A full "BigRedButton" build on my machine takes ~ 70 minutes so we'll most likely never see a completed Travis-ci build due to the 50 minute timeout, but compiling x86 works fine looking at logs.

Sh*t... :-/ I've just enabled Travis support, but if it last so much time then it will not work :-( OSX last too much time... :-/ Do you know of any other free online OSX CI server?

piranna commented 7 years ago

Seems GreenhouseCI supports OSX, but only for iOS apps... :-/

joshgarde commented 7 years ago

Sh*t... :-/ I've just enabled Travis support, but if it last so much time then it will not work :-( OSX last too much time... :-/ Do you know of any other free online OSX CI server?

I don't know any other free OS X CI services. OS X is just harder to host.

joshgarde commented 7 years ago

Am I approved for a merge?

piranna commented 7 years ago

Am I approved for a merge?

Some minor style changes and ready to merge :-) Also now TravisCI is doing the checking too... :-P

piranna commented 7 years ago

Definitely, osx in Travis is slow... :-(

joshgarde commented 7 years ago

I think the most that we can only get away with on Travis CI is a single build

piranna commented 7 years ago

I think the most that we can only get away with on Travis CI is a single build

Just for a simple platform instead of BigRedButton? What one do you suggest, x64?

joshgarde commented 7 years ago

Just for a simple platform instead of BigRedButton? What one do you suggest, x64?

Exactly what I was thinking - just for testing code updates. For prebuild generation, idk - might have to get a Mac VPS somewhere.