search

NodeRedis / node-redis-parser

A high performance Redis protocol (RESP) parser for JavaScript. Used by Node Redis & ioredis.
MIT License
88 stars 36 forks source link

Update Package.json - Move hiredis to dependencies #36

Closed christianpv closed 7 years ago

christianpv commented 7 years ago

Installing redis-parser with yarn does not install hiredis. I believe build is passing because we are running npm install hiredis in .travis.yml

Nevermind, I think it was another issue upstream. Thanks a lot for your time.

BridgeAR commented 7 years ago

I recommend not to use hiredis at all.

christianpv commented 7 years ago

Thanks for the recommendation but I'm not using it directly. I installed the ioredis package which has a dependency on redis-parser@^2.4.0. The package manager installs redis-parser@^2.6.0, and that version is using hiredis as a dependency in /lib/hiredis.js but its not listing it in its package.json dependencies. I'm going to make a PR to ioredis to required redis-parser@^3.0.0 but I would like to suggest that we find a way to add hiredis to package.json dependencies for redis-parser v2(I only know v2.6.0 is missing it).

codeimmortal commented 5 years ago

Is there is any progress on this ticket?