hiredis is not compiling in nodejs 12

NodeRedis / node-redis-parser

A high performance Redis protocol (RESP) parser for JavaScript. Used by Node Redis & ioredis.

MIT License

88 stars 36 forks source link

Closed rj-david closed 4 years ago

rj-david commented 5 years ago

Is there any way that this package will no longer depend on hiredis? Hiredis is not building properly using node-gyp in nodejs 12

stelcodes commented 5 years ago

I'm getting the same issue when building with parcel

sookoll commented 5 years ago

Any news on this? As hiredis is pretty much abonded, it should be removed as dependency.

EDIT: Ah, v3 it is removed already, node-redis still uses 2.6 and that was causing problems.

swateek commented 5 years ago

@sookoll could you install "redis"? I didn't quite understand your solution. Help?

yosiat commented 5 years ago

If you can upgrade the latest node-redis you don't need hiredis, it uses this repo which is fastest than hiredis as authors claim.

If you are like me and stuck at some version, you can use this fork https://github.com/redis/hiredis-node/pull/144 until the PR will get merged

swateek commented 5 years ago

I really didn't need hiredis. I moved to use "ioredis" and it works good for me.

Salakar commented 4 years ago

Hey all,

hiredis is no longer used in the latest parser, the the redis library has been updated to the latest parser version in https://github.com/NodeRedis/node_redis/commit/78936ac50c43ceb74654501a5da4b2994efe1217 (unreleased still, no eta).

Given that a fix is sat on master for this I'm going to go ahead and close this issue now. Thanks

ropre4 commented 3 years ago

It's been more than a year, can there be a new release to include this fix? redis-parser, and redis packages do not work on node 12 and node 14.