NodeSecure / cli

JavaScript security CLI that allow you to deeply analyze the dependency tree of a given package or local Node.js project.
MIT License
367 stars 39 forks source link

refactor: remove window.disableShortcuts #401

Closed PierreDemailly closed 4 months ago

targos commented 4 months ago

I don't think it's being handled in the right place. It should be the shortcut handler that checks whether the event target is an input element or similar, and do nothing when it's the case.

PierreDemailly commented 4 months ago

I don't think it's being handled in the right place. It should be the shortcut handler that checks whether the event target is an input element or similar, and do nothing when it's the case.

I agree, mb 👍 I removed window.disableShortcuts (and changed PR title), it works better now