NodeSecure / scanner

⚡️ A package API to run a static analysis of your module's dependencies. This is the CLI engine!

MIT License

27 stars 14 forks source link

Newtreewalker workspace #227

Closed badex-ai closed 2 months ago

badex-ai commented 3 months ago

ISSUE

226

DESCRIPTION: Created a new treewalker workspace and added the dependencies but only commented out the changes in the previous file just in case you would like to make adjustments. I am not perfect with my typescript yet (still learning and would like to learn more) but if there are any other changes that I need to get this merged pls let me know.

made changes to the i18n.taggedString function in "warning.ts" to include parenthesis (I don't know if this was a typo) added typescript interfaces "depwalker.ts" in the new folder.

fraxken commented 3 months ago

Hello @badex-ai,

You need to add the new workspace to tsconfig.json file
You also need a tsconfig in workspaces/treewalker (and remove the .gitkeep).
Do you have a prettier plugin enabled? If yes think to disable it.
Some files have a broken syntax and big spaces between codes (workspaces/treewalker/src/depWalker.ts)
You also need to migrate tests

And you need to update the original depWalker.js file to include the new dependency (all tests suites must run with no issues)

PierreDemailly commented 3 months ago

We also need a new ci workflow (.github/workflows/treewalker.yml)

PierreDemailly commented 3 months ago

Please also add a README

fraxken commented 2 months ago

Hello, I'm closing this in favor of https://github.com/NodeSecure/scanner/pull/236

Thanks for the effort / contribution.