Nodeclipse / nodeclipse

Nodeclipse-1 : Eclipse plugin for Node.js, PhantomJS development (Nodeclipse core plugin); Maven and Gradle (with Android) plugins
https://nodeclipse.github.io/
158 stars 78 forks source link

TMP and TEMP, etc... returns "null" string #127

Closed pchuong closed 10 years ago

pchuong commented 10 years ago

Hi,

It looks like the latest nodeclipse broke the process.env (PATH, TEMP, TMP, and SystemDrive) while debugging a nodejs process. These environment variables return "null" string literal instead of null (or undefined).

From this file, line 275 - line 278, it should check whether these java environment variables is not equals to null before adding it into the array.

https://github.com/Nodeclipse/nodeclipse-1/blob/master/org.nodeclipse.debug/src/org/nodeclipse/debug/launch/LaunchConfigurationDelegate.java#L275-278

Regards, Patrick

paulvi commented 10 years ago

Yes, indeed. I had the same issue in Maven plugin, but overlooked to fix for Node.js. It is fixed now. You can compile sources or wait 0.12 release in the end of March