Nodeclipse / nodeclipse

Nodeclipse-1 : Eclipse plugin for Node.js, PhantomJS development (Nodeclipse core plugin); Maven and Gradle (with Android) plugins
https://nodeclipse.github.io/
158 stars 78 forks source link

By default add Tern Nature #160

Closed paulvi closed 10 years ago

paulvi commented 10 years ago

@angelozerr Will be in 0.17

What is recommended .tern-project for Node project ? does it must to be always?

{"libs":["ecma5"],"plugins":{"node":{},"requirejs":{}},"ide":{}}

Is .tern-project understood by tern.js ?

What about ternBuilder ?

            <buildCommand>
        <name>tern.eclipse.ide.core.ternBuilder</name>
        <arguments>
        </arguments>
    </buildCommand>
paulvi commented 10 years ago

Maybe it is not good idea trying to configure Tern nature externally, that is not using tern.java API

angelozerr commented 10 years ago

Is .tern-project understood by tern.js ?

.tern-project is a file used by tern.js when it is loaded with node.

What about ternBuilder ?

Today it does nothing, perhaps I should remove it.

I think you should use the tern nature adapter extension point (like JBoss and Lifeay IDE use it). See https://github.com/angelozerr/tern.java/issues/99#issuecomment-48016895

paulvi commented 10 years ago

Is there dedicated wiki how integration should look like?

angelozerr commented 10 years ago

Ok please read t https://github.com/angelozerr/tern.java/wiki/Tern-IDE-Extension, I have updated the wiki to explain how to manage nodeclipse with tern.

paulvi commented 10 years ago

OK. Minimum is adding tern nature.

Nodeclipse has option to run not only with Node.js, but also PhantomJS, Vert.x, Java 8 jjs and mongodb shell.

They have different natures, but before it had no real usage.

Also there were idea to change org.nodeclipse.ui.NodeNature to org.nodeclipse.core.NodeNature, but now it would make some additional version compatibility issues.

angelozerr commented 10 years ago

Nodeclipse has option to run not only with Node.js, but also PhantomJS, Vert.x, Java 8 jjs and mongodb shell.

I think tern nature adapater extension point should be improved to add module with dynamic mean (with Java classes) and not only with static mean. With dynamic mean, you could check your natures or other thing and add the well module.

paulvi commented 10 years ago

So far only plan to update wizards to add .tern-project

Or maybe it can go without? What whould be default?

angelozerr commented 10 years ago

So far only plan to update wizards to add .tern-project

Why do you need some wizard?

.tern-project is generated automaticly when project has tern nature.

The Tern -> Modules project properties update .tern-project with selected modules.

If you need wizard, please create an issue by giving me more information

paulvi commented 10 years ago

I meant Nodeclipse Wizards. They have been before. Know I review what needs to be updated to support tern.

Will it be OK if .tern-project would initially be missing ?

angelozerr commented 10 years ago

You have 2 choices to add tern nature in a project with plugin :