Nodeclipse / nodeclipse

Nodeclipse-1 : Eclipse plugin for Node.js, PhantomJS development (Nodeclipse core plugin); Maven and Gradle (with Android) plugins
https://nodeclipse.github.io/
158 stars 76 forks source link

when toggling a breakpoint, get .js.chromium' does not exist". was: Question about the Chrome dev tool in Nodeclipse #173

Open RaymondQiu opened 10 years ago

RaymondQiu commented 10 years ago

Hey guys, I have a question about the Chrome dev tool in Nodeclipse. I saw a change that make the org.chromium.debug.ui.editors.JsEditor to extend the ComilationUnitEditor (JSDT JS editor). In my nodeclipse, I also installed JSDT plug-ins which included the org.eclipse.wst.jsdt.debug.ui plug-in.

When I tried to toggle a breakpoint in a virtual js file created by the chrome tools, I got an error saying "Resource '/ /C__DemoWorkspaces_Demo31_FirstApp_node_modules_express_lib_express.js.chromium' does not exist".

I investigated a little bit. The error was caused by org.eclipse.wst.jsdt.debug.internal.ui.breakpoints.ToggleBreakpointAdapter was used to toggled breakpoint instead of org.chromium.debug.core.model.LineBreakpointAdapter$ForVirtualProject and org.eclipse.wst.jsdt.debug.internal.ui.breakpoints.ToggleBreakpointAdapter could not recognized the virtual file. So that meant I can not have both nodeclipse and full JSDT together, right? Thanks.

paulvi commented 10 years ago

The breakpoint sync-ing was contributed by @tomotaro1065 , but he is silent for about a year, I cannot comment more then it is seen from the code.

But Nodeclipse is great together with full JSDT, so if at some point you see errors, that is bug.

Bugs should be raised with enough info about environment and how to reproduce .

Code changes are welcomed.

ghost commented 10 years ago

JSDT is not that great in my opinion as it's still hooked into ES3 when ES6 is now out there. Unfortunetely it's not optional — you can't remove ES3 JSDT as a plain package from your Eclipse installation. It's deeply bounded within Nodeclipse as far as I understand it therefore I don't see how it could provide a different path for any IDE task - debugging included. A typical problem is erroneous syntax checking like this one below:

screen shot 2014-10-21 at 09 19 21

This is wrong even for ES3: if 'default' was a key word even as data key within a json object then it should be colorized as such instead of raising a buggeous syntax error that will pollute my MEAN projects for ever...

paulvi commented 10 years ago

@nodeleaf Hi Patrick, this is not related to ES5 or ES6 support. Please create new issue if you want to collaborate on that.

ghost commented 10 years ago

@paulvi My point was: I don't see how JSDT could be used instead of Nodeclipse's - when you are using Nodeclipse IDE. If it was installed as a 'stand alone' plugin then this is not Nodeclipse but JSDT issue. Now about ES3 in JSDT: this is old story I re-instantiated above to expose one serious limit of JSDT among many others. As far as I understand it, ES5 support in JSDT 3.6 was deferred therefore I am afraid there is not much to collaborate about this topic — beside getting rid of JSDT in Nodeclipse but this is hardly an option don't you think?

paulvi commented 6 years ago

very old discussion.

maybe should be close as is (especially if quiet)

dPhantum commented 6 years ago

This is still an issue in Eclipse, I am using the Eclipse PDT and it is never ending popping up.

dPhantum commented 6 years ago

So it looks like the fix is to remove the NodeEclipse plugin. If I don't hear back I suppose there is no resolution.

paulvi commented 6 years ago

"never ending popping up" is new issue.

@dPhantum Can you put screenshot and some entries in Error Log

image

as new issue

dPhantum commented 6 years ago

New issue created, see https://github.com/Nodeclipse/nodeclipse-1/issues/224