search

Nodeclipse / nodeclipse

Nodeclipse-1 : Eclipse plugin for Node.js, PhantomJS development (Nodeclipse core plugin); Maven and Gradle (with Android) plugins
https://nodeclipse.github.io/
158 stars 78 forks source link

Eclipse VM version #179

Closed ghost closed 9 years ago

ghost commented 9 years ago

This issue could be a platform issue but the -vm argument is not set like it should according to this: https://wiki.eclipse.org/Eclipse.ini

I am using Eclipse Luna on MacOS X Yosemite with Java 1.6 and 1.8 installed.

After I installed 1.8 I assumed Eclipse will use it but I might be wrong as this is not set in eclipse.ini.

The -vm argument reads like this: -vmargs

And on the line below I can read this: -Dosgi.requiredJavaVersion=1.6

So it might be using Java 1.6 - how do I know?

Is it not possible to select a VM from Eclipse preferences instead of hacking eclipse.ini?

paulvi commented 9 years ago

There are millions of Eclipse users, and this is very basic feature, there is hardly a bug.

What is your full eclipse.ini content?

As for -Dosgi.requiredJavaVersion=1.6 it is OSGI stuff, and not about what JDK to use

ghost commented 9 years ago 
-startup
../../../plugins/org.eclipse.equinox.launcher_1.3.0.v20140415-2008.jar
--launcher.library
../../../plugins/org.eclipse.equinox.launcher.cocoa.macosx.x86_64_1.1.200.v20140603-1326
-product
org.eclipse.epp.package.jee.product
--launcher.defaultAction
openFile
-showsplash
org.eclipse.platform
--launcher.XXMaxPermSize
256m
--launcher.defaultAction
openFile
--launcher.appendVmargs
-vmargs
-Dosgi.requiredJavaVersion=1.6
-XstartOnFirstThread
-Dorg.eclipse.swt.internal.carbon.smallFonts
-XX:MaxPermSize=256m
-Xms40m
-Xmx512m
-Xdock:icon=../Resources/Eclipse.icns
-XstartOnFirstThread
-Dorg.eclipse.swt.internal.carbon.smallFonts
paulvi commented 9 years ago

Have you read https://wiki.eclipse.org/Eclipse.ini ?

add 2 lines before -vmargs

like

 -vm
/System/Library/Frameworks/JavaVM.framework/Versions/1.6.0/Home/bin/java
ghost commented 9 years ago

Reading you I understood the VM version Eclipse was using was actually specified in eclipse.ini so I looked to make sure the changes I made at system level to use 1.8 were visible in there but they are not.

Now I understand the -vm argument could be used only to select a different VM - but I don't need that...

paulvi commented 9 years ago

you need something like https://github.com/Nodeclipse/nodeclipse-1/blob/master/org.nodeclipse.enide.maven/.settings/org.eclipse.jdt.core.prefs