search

Nodeclipse / nodeclipse

Nodeclipse-1 : Eclipse plugin for Node.js, PhantomJS development (Nodeclipse core plugin); Maven and Gradle (with Android) plugins
https://nodeclipse.github.io/
158 stars 76 forks source link

Nodeclipse issue #189 - workaround for node issue 25266 #193

Closed swingfield closed 9 years ago

swingfield commented 9 years ago

Pull request that addresses Nodeclipse issue #189.

This is a workaround for node issue joyent/node#25358, where node seems to be generating 'compileError' events instead of 'afterCompile' events. This causes Nodeclipse to miss the chance to process new scripts as they are pulled into a running application, as Nodeclipse is listening for the afterCompile events.

As discussed in Nodeclipse issue #189, if this does in fact turn out to be a node issue, then presumably this workaround would be version-specific, and would only need to be activated for certain versions of node.

paulvi commented 9 years ago

That makes it very clear what is to be changed. Next thing would be make a preference for that.

Short: Treat compileError as afterCompile (joyent/node#25358)

Description: Treat the "compileError" event as the "afterCompile" event (for Node v0.11.14..0.12.2, joyent/node#25358)

Do you think short string would be enough?

swingfield commented 9 years ago

I think i'd go with something like "Treat Node Debugger compileError event as afterCompile (joyent/node#25266). The reasoning because...

Also, I would use joyent/node#25266 instead of joyent/node#23538. I think joyent/node#25266 matches more closely to what we experienced in this situation.

paulvi commented 9 years ago

workaround for node issue 25266

@swingfield Is joyent/node#25266 the same as joyent/node#25358 ?

swingfield commented 9 years ago

I'm not familiar with node issue 25358. But reading it, I do see that someone has linked that issue with node issue 25266, so maybe they are related in some way. But I think 25266 more clearly states the root of the problem that we are addressing in this Nodeclipse issue.

paulvi commented 9 years ago

OK, as I said now it is my turn to come out with preference checkbox