search

NoelDeMartin / media-kraken

Track your movies with Media Kraken
https://noeldemartin.github.io/media-kraken/
GNU General Public License v3.0
71 stars 6 forks source link

wrong privateTypeIndex creation #15

Closed bourgeoa closed 2 years ago

bourgeoa commented 2 years ago

Using media-kraken app on css https://solidweb.me/bourgeoa/, /settings/privateTypeIndex.ttl is missing. Your app creates one but with a different name /settings/privateTypeIndex without .ttl at the end.

Is it on purpose ? I thought that to stay on NSS structure would make thinks simpler as it is already tricky.

NoelDeMartin commented 2 years ago

Hey, thanks for opening an issue.

Yes, it is on purpose, I usually don't end document urls with .ttl given that it's an implementation detail. I don't know if the POD is storing a document in turtle files, and technically you could request a document in other formats such as JSONLD. So I just don't use an extension for documents that my app creates.

If the type index already exists, and it ends with .ttl, that shouldn't be a problem for the app and it won't create a new file. So I think that's fine. The important part is that the type index is listed on a user's profile, the exact url shouldn't matter.

Did this cause any issue for you?

bourgeoa commented 2 years ago

No. I agree it is working. And when you follow your nose you are correct. I forgot that.

I just think it make things less easy to read. The same with having no extension for files.

You can close the issue.

NoelDeMartin commented 2 years ago

Ok, thanks for raising the point.