search

NoelDeMartin / media-kraken

Track your movies with Media Kraken
https://noeldemartin.github.io/media-kraken/
GNU General Public License v3.0
71 stars 6 forks source link

Full url used as subject in turtle resource #8

Closed bourgeoa closed 3 years ago

bourgeoa commented 3 years ago

The recent closing of solid.community server had the consequence that your app did not work anymore. I had to rename all the movies using the new solidcommunity.net as subject in turtle file.

I tried to make a relative link, but it does not seem to work. Is it in relation with the service worker ?

NoelDeMartin commented 3 years ago

Hi there, thanks for opening the issue.

I've been looking into this and most movies are created with absolute urls (which, seeing how things turned out, I'll try to change). But there are some that have relative urls, those are the ones that are marked as watched after adding them. The reason is that for new documents I am using POST so the document is stored as I send it, but for updates I am using PATCH with solid operations and the server must be doing some optimizations to store relative urls.

So relative urls should work, because that's how movies you've modified after adding them to your collection are stored. I'm not sure if it's the service worker's fault, but maybe you can try logging in a different browser to see if it works as expected. I'd also try to log out and log in again because models are cached in the browser to speed up the boot up.

Also, when you say it doesn't work what do you mean? You get an error, or some movies are missing?

bourgeoa commented 3 years ago

I made relative links with solid-ideI on Forrest Gump has example Make a search select watched and got a 500 error

NoelDeMartin commented 3 years ago

Ok, I'll do some tests to see if I can reproduce it.

In any case, I've been working on a version with improved error reporting so if I haven't been able to reproduce this, I'll let you know when I release the new version to see if we can get more details about the problem.

NoelDeMartin commented 3 years ago

I just released a new version that not only fixes this for new documents, but also migrates existing data in your POD to have the proper format :). You can read more about how that works here: Schema Migration.

Let me know if you've got any problems with that.