NoelDeMartin / umai

Offline-first Recipes Manager
https://umai.noeldemartin.com
GNU General Public License v3.0
32 stars 5 forks source link

Direct link to recipe could offer user to login #18

Open josephguillaume opened 4 months ago

josephguillaume commented 4 months ago

If I paste a link to a recipe directly in a browser where I am not logged in, I get 404: Not Found with a link to go home.

Instead of going home, logging in, and trying again, it would be useful to be offered to login directly on that page.

This assumes the link is indeed valid - if the user has actually pasted a link from someone else's pod instead of using the viewer, then this wouldn't work. Given that the url does not encode any information about the pod, logging in is probably the only way to tell anyway.

NoelDeMartin commented 4 months ago

Hey, thanks for opening an issue!

I think that's good idea, I'll look into it next time I do a release.

For the longer term, though, I'm still not convinced that this approach of having "pretty urls" is the best for Solid Apps. As we discussed in the forum, one alterantive is having the recipe url encoded in the path, so for example instead of /recipes/ramen the path would be /recipes/https%3A%2F%2Fpod.example.com%2Fcookbook%2Framen%23it. That would remove this problem, and the need for a "viewer" altogether. But I'm still not convinced that having "ugly urls" is ultimately better :/.

So yeah, I don't know what I'll do in the end. But I'm still using pretty urls in the work I'm currently doing, so I guess this will continue being a problem.