search

Nogrod / dhl-shipping-php-sdk

MIT License
0 stars 0 forks source link

too strict requirements for label creation #1

Open easisi opened 2 months ago

easisi commented 2 months ago

hi,

i used this library for my webshop and to really create a label there are some parameters in Consignee ans Shipment that are not required for label creation. not only that - if you would supply them the label creation would fail (i.e. packstation ID).

also the response from dhl gives out a new label print format that isnt available to deserialize. (900-300-400/410).

i think the required fields are also not required in the openapi yaml by dhl. the document format is not listed by them though..

easisi commented 2 months ago

fyi. for now i added the document type manually in the code and made the variables optional in the according get-functions. i can submit a pull request. but i dont think thats the way with openAPI..

Nogrod commented 2 months ago

hey, yes sorry, right now it seems that the openAPI generator for php does not support oneOf and anyOf specs which are used by DHL in the yaml. waiting for a fix on openAPI side, so you can only manually patch it for now.