Open kvnbias opened 5 years ago
@NoiSek
How does a user export config values from the theme to a greeter-config friendly format?
As of now, according to the API (Warning SSL in the website is expired) there is currently no way to write on external files.
When a setting is changed while an external config is active, what is the expected result?
As of now, the changes will persist on the localStorage, config file will be untouched due to API's limitations, requiring the user to uncheck the Use .conf setting
. Leaving the Use .conf setting
checked won't show the changes next login unless the setting is turned off.
When the external config is active, should settings be disabled entirely?
This can be a nice feature to add.
When the user attempts to edit the external config, should an error be surfaced to the user?
While the config can be confusing since a normal linux user may not know the settings will be injected as a CSS value, it will take time to create a parser and it will be useless since if lightdm-webkit see's an error, lightdm-webkit will just prompt to use their default theme(antergos) instead.
Given that the relationship is one-way (read only), should it be expected that once you enable the external config you always use the external config? Having config values fall through to whatever their current localStorage value is does not seem like desired behavior or good UX.
Once the conf setting is enabled, the external config is always used. However if the user doesn't know a certain setting can be placed in the config, I prefer to show the default/localStorage value than using uncustomizeable values. But I do agree that current behavior is undesired. A solution can be: Disable all settings if external settings is checked, But leave the setting customizable if it doesn't exists in the config file
Features
Pull request: #48
Why? QOL for users who seldom change themes using the cli. Just like GTK apps, the theme will change instantly when the config file is updated. The config will be
/etc/lightdm/lightdm-webkit2-greeter.conf
. Sample config file: