search

NoiseByNorthwest / php-spx

A simple & straight-to-the-point PHP profiling extension with its built-in web UI
GNU General Public License v3.0
2.09k stars 81 forks source link

Link to code.jquery.com #217

Open pilot114 opened 1 year ago

pilot114 commented 1 year ago

image Web UI don't work without internet connection (if browser cache is clear)

NoiseByNorthwest commented 1 year ago

I'm sorry for that. The next move I will do or accept about JQuery is just dropping it.

BafS commented 2 months ago

Would you accept to inline jquery in the 2 html files as an easy workaround? Our staging environment has to have a specific CSP policy just because of this

NoiseByNorthwest commented 2 months ago

Instead of inlining it I prefer using a local snapshot of jquery (.min.js) in order to keep the integrity check (integrity="sha256-hwg4gsxgFZhOsEEamdOYGBf13FyQuiTwlAQgxVSNgt4=")

NoiseByNorthwest commented 2 months ago

I guess

<script src="https://code.jquery.com/jquery-3.2.1.min.js"
        integrity="sha256-hwg4gsxgFZhOsEEamdOYGBf13FyQuiTwlAQgxVSNgt4=" crossorigin="anonymous"></script>

would be replaced by

<script src="js/jquery-3.2.1.min.js"
        integrity="sha256-hwg4gsxgFZhOsEEamdOYGBf13FyQuiTwlAQgxVSNgt4="></script>
BafS commented 2 months ago

Ok, I did a PR to move the external JS to assets: https://github.com/NoiseByNorthwest/php-spx/pull/248